linux-kernel - [RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a2cc3ac9466633ea44a656a855ed80289ae917e0.1750905716.git.tanggeliang@kylinos.cn>
Date: Thu, 26 Jun 2025 10:48:07 +0800
From: Geliang Tang <geliang@...nel.org>
To: Lee Jones <lee@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>,
	Tony Lindgren <tony@...mide.com>
Cc: Geliang Tang <tanggeliang@...inos.cn>,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: [RESEND PATCH mfd-next v2] mfd: Drop unused variables 'node'

From: Geliang Tang <tanggeliang@...inos.cn>

This patch drops the unused variables 'node' to fix the following build
warnings:

drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
drivers/mfd/88pm860x-core.c:576:29: warning: unused variable 'node' [-Wunused-variable]
  576 |         struct device_node *node = i2c->dev.of_node;
      |                             ^~~~

drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
drivers/mfd/max8925-core.c:659:29: warning: unused variable 'node' [-Wunused-variable]
  659 |         struct device_node *node = chip->dev->of_node;
      |                             ^~~~

drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
drivers/mfd/twl4030-irq.c:679:46: warning: unused variable 'node' [-Wunused-variable]
  679 |         struct                  device_node *node = dev->of_node;
      |                                              ^~~~

Signed-off-by: Geliang Tang <tanggeliang@...inos.cn>
---
RESEND:
 - cc more people.
v2:
 - drop unused variables 'node' in max8925-core.c and twl4030-irq.c too.
---
 drivers/mfd/88pm860x-core.c | 1 -
 drivers/mfd/max8925-core.c  | 1 -
 drivers/mfd/twl4030-irq.c   | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 488e346047c1..750f9db95386 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -573,7 +573,6 @@ static int device_irq_init(struct pm860x_chip *chip,
 	unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
 	int data, mask, ret = -EINVAL;
 	int nr_irqs, irq_base = -1;
-	struct device_node *node = i2c->dev.of_node;
 
 	mask = PM8607_B0_MISC1_INV_INT | PM8607_B0_MISC1_INT_CLEAR
 		| PM8607_B0_MISC1_INT_MASK;
diff --git a/drivers/mfd/max8925-core.c b/drivers/mfd/max8925-core.c
index 78b16c67a5fc..9d6358337d97 100644
--- a/drivers/mfd/max8925-core.c
+++ b/drivers/mfd/max8925-core.c
@@ -656,7 +656,6 @@ static int max8925_irq_init(struct max8925_chip *chip, int irq,
 {
 	unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
 	int ret;
-	struct device_node *node = chip->dev->of_node;
 
 	/* clear all interrupts */
 	max8925_reg_read(chip->i2c, MAX8925_CHG_IRQ1);
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..c95a73186112 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 	static struct irq_chip	twl4030_irq_chip;
 	int			status, i;
 	int			irq_base, irq_end, nr_irqs;
-	struct			device_node *node = dev->of_node;
 
 	/*
 	 * TWL core and pwr interrupts must be contiguous because
-- 
2.48.1