linux-kernel - Re: [PATCH v3 0/4] Fix soc-button-array debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF1anq07UAkHCfPO@smile.fi.intel.com>
Date: Thu, 26 Jun 2025 17:35:10 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mario Limonciello <superm1@...nel.org>
Cc: Hans de Goede <hansg@...nel.org>, Mika Westerberg <westeri@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"open list:GPIO ACPI SUPPORT" <linux-gpio@...r.kernel.org>,
	"open list:GPIO ACPI SUPPORT" <linux-acpi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v3 0/4] Fix soc-button-array debounce

On Wed, Jun 25, 2025 at 04:58:09PM -0500, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@....com>
> 
> I have some hardware in front of me that uses the soc-button-array
> driver but the power button doesn't work.
> 
> Digging into it, it's because the ASL prescribes a debounce of 0 for
> the power button, but the soc-button-array driver hardcodes 50ms.
> 
> Hardcoding it to what the ASL expects the power button works.
> 
> I looked at the callpath into the GPIO core and I believe it's
> because the debounce value from _CRS is never programmed to the
> hardware the way that the GPIO gets setup.
> 
> This series add that programming path and then sets the hardcoded
> value on on some quirked systems.  Hopefully Hans can confirm this
> continues to work on the hardware that he originally developed the
> hardcoding for.

There is no a note about routing the patch in upstream. My proposal to take
GPIO ACPI library patch and provide and immutable tag for others.

-- 
With Best Regards,
Andy Shevchenko