linux-kernel - Re: [PATCH v3 4/4] Input: Don't send fake button presses to wake system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF1bG_iCMpYUhQj0@smile.fi.intel.com>
Date: Thu, 26 Jun 2025 17:37:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mario Limonciello <superm1@...nel.org>
Cc: Hans de Goede <hansg@...nel.org>, Mika Westerberg <westeri@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"open list:GPIO ACPI SUPPORT" <linux-gpio@...r.kernel.org>,
	"open list:GPIO ACPI SUPPORT" <linux-acpi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v3 4/4] Input: Don't send fake button presses to wake
 system

On Wed, Jun 25, 2025 at 04:58:13PM -0500, Mario Limonciello wrote:
> 
> Sending an input event to wake a system does wake it, but userspace picks
> up the keypress and processes it.  This isn't the intended behavior as it
> causes a suspended system to wake up and then potentially turn off if
> userspace is configured to turn off on power button presses.
> 
> Instead send a PM wakeup event for the PM core to handle waking the system.

It seems the Subject is incorrect WRT the pattern used in input subsystem
(in this and in the previous patches).

Should be something like: Input: $driver - $summary

where $driver and $summary the exact driver name and summary you want to put.

-- 
With Best Regards,
Andy Shevchenko