linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: Add support for QCS8275 IQ8 EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFy9Sc3zVjBB/8J0@hu-bjorande-lv.qualcomm.com>
Date: Wed, 25 Jun 2025 20:23:53 -0700
From: Bjorn Andersson <bjorn.andersson@....qualcomm.com>
To: Umang Chheda <umang.chheda@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@....qualcomm.com, Rakesh Kota <quic_kotarake@...cinc.com>,
        Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>,
        Swati Agarwal <quic_swatagar@...cinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add support for QCS8275 IQ8 EVK

On Mon, Jun 23, 2025 at 06:34:20PM +0530, Umang Chheda wrote:
> Add initial device tree support for IQ-8275-EVK board,
> based on Qualcomm's QCS8275 SOC.
> 
> Implement basic features like DSPs, UFS and 'booting to shell'
> with uart console.
> 
> Co-developed-by: Rakesh Kota <quic_kotarake@...cinc.com>
> Signed-off-by: Rakesh Kota <quic_kotarake@...cinc.com>
> Co-developed-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> Signed-off-by: Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>
> Co-developed-by: Swati Agarwal <quic_swatagar@...cinc.com>
> Signed-off-by: Swati Agarwal <quic_swatagar@...cinc.com>
> Signed-off-by: Umang Chheda <umang.chheda@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/qcs8275-iq-8275-evk.dts     | 241 ++++++++++++++++++
>  2 files changed, 242 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qcs8275-iq-8275-evk.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 669b888b27a1..417d8c9be4e2 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -122,6 +122,7 @@ qcs6490-rb3gen2-industrial-mezzanine-dtbs := qcs6490-rb3gen2.dtb qcs6490-rb3gen2
>  
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2-industrial-mezzanine.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs6490-rb3gen2-vision-mezzanine.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= qcs8275-iq-8275-evk.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs8300-ride.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs8550-aim300-aiot.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcs9100-ride.dtb
> diff --git a/arch/arm64/boot/dts/qcom/qcs8275-iq-8275-evk.dts b/arch/arm64/boot/dts/qcom/qcs8275-iq-8275-evk.dts
> new file mode 100644
> index 000000000000..b17ddb3ef721
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs8275-iq-8275-evk.dts

Please prefix new Monaco-based boards monaco-.

As with the compatible, would monaco-evk.dts be sufficiently unique?

> @@ -0,0 +1,241 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "qcs8300.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. IQ 8275 EVK";

The model looks okay.

> +	compatible = "qcom,qcs8275-iq-8275-evk", "qcom,qcs8275", "qcom,qcs8300";

Please update this according to the bindings update.

Regards,
Bjorn