linux-kernel - Re: [PATCH 04/12] irqchip/imx-mu-msi: Convert to msi_create_parent_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF1wZJV6U9c7bnX6@lizhi-Precision-Tower-5810>
Date: Thu, 26 Jun 2025 12:08:04 -0400
From: Frank Li <Frank.li@....com>
To: Nam Cao <namcao@...utronix.de>
Cc: Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Antoine Tenart <atenart@...nel.org>, Andrew Lunn <andrew@...n.ch>,
	Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Huacai Chen <chenhuacai@...nel.org>,
	Jiaxun Yang <jiaxun.yang@...goat.com>,
	Anup Patel <anup@...infault.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev, linux-mips@...r.kernel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 04/12] irqchip/imx-mu-msi: Convert to
 msi_create_parent_irq_domain() helper

On Thu, Jun 26, 2025 at 04:49:01PM +0200, Nam Cao wrote:
> From: Marc Zyngier <maz@...nel.org>
>
> Now that we have a concise helper to create an MSI parent domain,
> switch the IMX letter soup over to that.
>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Link: https://lore.kernel.org/all/20241204124549.607054-7-maz@kernel.org

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: imx@...ts.linux.dev
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
>  drivers/irqchip/irq-imx-mu-msi.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c
> index 137da1927d144..d2a4e8a61a42b 100644
> --- a/drivers/irqchip/irq-imx-mu-msi.c
> +++ b/drivers/irqchip/irq-imx-mu-msi.c
> @@ -223,21 +223,21 @@ static const struct msi_parent_ops imx_mu_msi_parent_ops = {
>
>  static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev)
>  {
> -	struct fwnode_handle *fwnodes = dev_fwnode(dev);
> +	struct irq_domain_info info = {
> +		.ops		= &imx_mu_msi_domain_ops,
> +		.fwnode		= dev_fwnode(dev),
> +		.size		= IMX_MU_CHANS,
> +		.host_data	= msi_data,
> +	};
>  	struct irq_domain *parent;
>
>  	/* Initialize MSI domain parent */
> -	parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS,
> -					  &imx_mu_msi_domain_ops, msi_data);
> +	parent = msi_create_parent_irq_domain(&info, &imx_mu_msi_parent_ops);
>  	if (!parent) {
>  		dev_err(dev, "failed to create IRQ domain\n");
>  		return -ENOMEM;
>  	}
> -
> -	irq_domain_update_bus_token(parent, DOMAIN_BUS_NEXUS);
>  	parent->dev = parent->pm_dev = dev;
> -	parent->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT;
> -	parent->msi_parent_ops = &imx_mu_msi_parent_ops;
>  	return 0;
>  }
>
> --
> 2.39.5
>