linux-kernel - Re: [PATCH 1/2] binder: use kstrdup() in binderfs_binder_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbx8sejme7gf.fsf@ynaffit-andsys.c.googlers.com>
Date: Thu, 26 Jun 2025 10:30:40 -0700
From: Tiffany Yang <ynaffit@...gle.com>
To: Dmitry Antipov <dmantipov@...dex.ru>
Cc: Carlos Llamas <cmllamas@...gle.com>,  Arve Hjønnevåg
 <arve@...roid.com>,
  Todd Kjos <tkjos@...roid.com>,  Martijn Coenen <maco@...roid.com>,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] binder: use kstrdup() in
 binderfs_binder_device_create()

Dmitry Antipov <dmantipov@...dex.ru> writes:

> In 'binderfs_binder_device_create()', use 'kstrdup()' to copy the
> newly created device's name, thus making the former a bit simpler.
>
> Signed-off-by: Dmitry Antipov <dmantipov@...dex.ru>
> ---
>  drivers/android/binderfs.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 024275dbfdd8..4f827152d18e 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -117,7 +117,6 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
>  	struct dentry *dentry, *root;
>  	struct binder_device *device;
>  	char *name = NULL;
> -	size_t name_len;
>  	struct inode *inode = NULL;
>  	struct super_block *sb = ref_inode->i_sb;
>  	struct binderfs_info *info = sb->s_fs_info;
> @@ -161,9 +160,7 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
>  	inode->i_gid = info->root_gid;
>  
>  	req->name[BINDERFS_MAX_NAME] = '\0'; /* NUL-terminate */
> -	name_len = strlen(req->name);
> -	/* Make sure to include terminating NUL byte */
> -	name = kmemdup(req->name, name_len + 1, GFP_KERNEL);
> +	name = kstrdup(req->name, GFP_KERNEL);
>  	if (!name)
>  		goto err;

Reviewed-by: Tiffany Y. Yang <ynaffit@...gle.com>

-- 
Tiffany Y. Yang