linux-kernel - Re: [PATCH] scsi: Format scsi_track_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89c663de-35bb-4a40-b547-19512319d28d@gmail.com>
Date: Fri, 27 Jun 2025 06:08:24 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Bart Van Assche <bvanassche@....org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux SCSI <linux-scsi@...r.kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Rob Landley <rob@...dley.net>
Subject: Re: [PATCH] scsi: Format scsi_track_queue_full() return values as
 bullet list

On 6/26/25 23:16, Bart Van Assche wrote:
> On 6/25/25 9:18 PM, Bagas Sanjaya wrote:
>> - * Returns:    0 - No change needed, >0 - Adjust queue depth to this 
>> new depth,
>> - *         -1 - Drop back to untagged operation using host->cmd_per_lun
>> - *             as the untagged command depth
>> + * Returns:    * 0 - No change needed
>> + *        * >0 - Adjust queue depth to this new depth,
>> + *         * -1 - Drop back to untagged operation using host- 
>> >cmd_per_lun
>> + *           as the untagged command depth
>>    *
>>    * Lock Status:    None held on entry
>>    *
> 
> Here is an example from Documentation/doc-guide/kernel-doc.rst:
> 
>        * Return:
>        * * %0        - OK to runtime suspend the device
>        * * %-EBUSY    - Device should not be runtime suspended
> 
> Wouldn't it be better to follow that example and to move the list under
> 'Returns:' and to move it more to the left?
> 

Ack.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara