linux-kernel - RE: [PATCH] media: i2c: imx334: add support for additional test patterns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH0PR11MB561123C9612EF7E82A0530E5817AA@PH0PR11MB5611.namprd11.prod.outlook.com>
Date: Thu, 26 Jun 2025 07:09:07 +0000
From: <Shravan.Chippa@...rochip.com>
To: <kieran.bingham@...asonboard.com>, <mchehab@...nel.org>,
	<sakari.ailus@...ux.intel.com>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<Conor.Dooley@...rochip.com>, <Valentina.FernandezAlanis@...rochip.com>,
	<Praveen.Kumar@...rochip.com>
Subject: RE: [PATCH] media: i2c: imx334: add support for additional test
 patterns

Hi Kieran,


> -----Original Message-----
> From: Kieran Bingham <kieran.bingham@...asonboard.com>
> Sent: Tuesday, June 24, 2025 3:28 PM
> To: mchehab@...nel.org; sakari.ailus@...ux.intel.com; shravan Chippa -
> I35088 <Shravan.Chippa@...rochip.com>
> Cc: linux-media@...r.kernel.org; linux-kernel@...r.kernel.org; Conor Dooley -
> M52691 <Conor.Dooley@...rochip.com>; Valentina Fernandez Alanis -
> M63239 <Valentina.FernandezAlanis@...rochip.com>; Praveen Kumar -
> I30718 <Praveen.Kumar@...rochip.com>; shravan Chippa - I35088
> <Shravan.Chippa@...rochip.com>
> Subject: Re: [PATCH] media: i2c: imx334: add support for additional test
> patterns
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Shravan
> 
> Quoting shravan kumar (2025-06-24 07:54:38)
> > From: Shravan Chippa <shravan.chippa@...rochip.com>
> >
> > Added support for three additional test patterns in the
> > IMX334 driver: Black and Grey Bars, Black Color, and White Color.
> >
> > Signed-off-by: Shravan Chippa <shravan.chippa@...rochip.com>
> > ---
> >  drivers/media/i2c/imx334.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> > index 846b9928d4e8..43dd7edb48c8 100644
> > --- a/drivers/media/i2c/imx334.c
> > +++ b/drivers/media/i2c/imx334.c
> > @@ -118,6 +118,9 @@
> >  #define IMX334_REG_TP                  CCI_REG8(0x329e)
> >  #define IMX334_TP_COLOR_HBARS          0xa
> >  #define IMX334_TP_COLOR_VBARS          0xb
> > +#define IMX334_TP_BLACK                        0x0
> > +#define IMX334_TP_WHITE                        0x1
> > +#define IMX334_TP_BLACK_GREY           0xC
> 
> This should be lower case to match the other hex constants (0xc)
> 
> I also wonder if this list should be in register address order ... but then it won't
> match the menu items ...

This is just value to write in the register

Thanks,
Shravan

> 
> >
> >  #define IMX334_TPG_EN_DOUT             CCI_REG8(0x329c)
> >  #define IMX334_TP_ENABLE               0x1
> > @@ -398,12 +401,18 @@ static const char * const
> imx334_test_pattern_menu[] = {
> >         "Disabled",
> >         "Vertical Color Bars",
> >         "Horizontal Color Bars",
> > +       "Black and Grey Bars",
> > +       "Black Color",
> > +       "White Color",
> >  };
> >
> >  static const int imx334_test_pattern_val[] = {
> >         IMX334_TP_DISABLE,
> >         IMX334_TP_COLOR_HBARS,
> >         IMX334_TP_COLOR_VBARS,
> > +       IMX334_TP_BLACK_GREY,
> > +       IMX334_TP_BLACK,
> > +       IMX334_TP_WHITE,
> >  };
> >
> >  static const struct cci_reg_sequence raw10_framefmt_regs[] = {
> > --
> > 2.34.1
> >