linux-kernel - Re: [PATCH] net: fec: allow disable coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d60808b3-eb20-40ab-b952-d9cd8d8d68a7@lunn.ch>
Date: Thu, 26 Jun 2025 10:12:07 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Wei Fang <wei.fang@....com>
Cc: Jonas Rebmann <jre@...gutronix.de>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	Shenwei Wang <shenwei.wang@....com>,
	Clark Wang <xiaoning.wang@....com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH] net: fec: allow disable coalescing

On Thu, Jun 26, 2025 at 02:36:37AM +0000, Wei Fang wrote:
> >  static void fec_enet_itr_coal_set(struct net_device *ndev)
> >  {
> >         struct fec_enet_private *fep = netdev_priv(ndev);
> > -       int rx_itr, tx_itr;
> > +       int rx_itr = 0, tx_itr = 0;
> 
> Since you modified this line, it would be a good idea to change
> the type to u32.
> 
> > 
> > -       /* Must be greater than zero to avoid unpredictable behavior */
> > -       if (!fep->rx_time_itr || !fep->rx_pkts_itr ||
> > -           !fep->tx_time_itr || !fep->tx_pkts_itr)
> > -               return;

Hi Wei

When i see a comment like this being removed, i wounder if there is
any danger of side effects? Do you know what is being done here is
actually safe, for all the different versions of the FEC which support
coalescence?

Thanks
	Andrew