linux-kernel - Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250626083018.GB8738@pendragon.ideasonboard.com>
Date: Thu, 26 Jun 2025 11:30:18 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Frank Li <Frank.Li@....com>, Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in
 imx8mq_mipi_csi_parse_dt()

On Thu, Jun 26, 2025 at 03:32:50AM +0300, Dan Carpenter wrote:
> On Thu, Jun 26, 2025 at 03:20:53AM +0300, Laurent Pinchart wrote:
> > On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> > > This was returning IS_ERR() where PTR_ERR() was intended.
> > > 
> > > Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> > 
> > I'll add a
> > 
> > Cc: stable@...r.kernel.org
> > 
> > to obey the media subsystem CI rules.
> 
> Wait, what?  The original commit hasn't hit Linus's tree and it's
> not marked for stable either.

I'm personally not in favour of adding Cc: stable on all patches that
have a Fixes: line. I'll let Mauro defend the rule, and I'm happy to
drop the Cc line and fix the CI.

-- 
Regards,

Laurent Pinchart