linux-kernel - Re: [PATCH v11 14/14] unwind_user/x86: Enable compat mode frame pointer unwinding on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF0FwYq1ECJV5Fdi@gmail.com>
Date: Thu, 26 Jun 2025 10:33:05 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	bpf@...r.kernel.org, x86@...nel.org,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrii Nakryiko <andrii@...nel.org>,
	Indu Bhagat <indu.bhagat@...cle.com>,
	"Jose E. Marchesi" <jemarch@....org>,
	Beau Belgrave <beaub@...ux.microsoft.com>,
	Jens Remus <jremus@...ux.ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v11 14/14] unwind_user/x86: Enable compat mode frame
 pointer unwinding on x86


* Steven Rostedt <rostedt@...dmis.org> wrote:

> diff --git a/arch/x86/include/asm/unwind_user_types.h b/arch/x86/include/asm/unwind_user_types.h
> new file mode 100644
> index 000000000000..d7074dc5f0ce
> --- /dev/null
> +++ b/arch/x86/include/asm/unwind_user_types.h
> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _ASM_UNWIND_USER_TYPES_H
> +#define _ASM_UNWIND_USER_TYPES_H

This is not the standard x86 header guard pattern ...

> +
> +#ifdef CONFIG_IA32_EMULATION
> +
> +struct arch_unwind_user_state {
> +	unsigned long ss_base;
> +	unsigned long cs_base;
> +};
> +#define arch_unwind_user_state arch_unwind_user_state

Ran out of newlines? ;-)

> +/*
> + * If an architecture needs to initialize the state for a specific
> + * reason, for example, it may need to do something different
> + * in compat mode, it can define arch_unwind_user_init to a
> + * function that will perform this initialization.

Please use 'func()' when referring to functions in comments.

> +/*
> + * If an architecture requires some more updates to the state between
> + * stack frames, it can define arch_unwind_user_next to a function
> + * that will update the state between reading stack frames during
> + * the user space stack walk.

Ditto.

Thanks,

	Ingo