linux-kernel - [PATCH net-next v2 0/9] net: Remove unused function parameters in skbuff.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250626-splice-drop-unused-v2-0-3268fac1af89@rbox.co>
Date: Thu, 26 Jun 2025 10:33:33 +0200
From: Michal Luczaj <mhal@...x.co>
To: "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
 Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
 David Ahern <dsahern@...nel.org>, Boris Pismenny <borisp@...dia.com>, 
 John Fastabend <john.fastabend@...il.com>, 
 Ayush Sawal <ayush.sawal@...lsio.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
 Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>, 
 "D. Wythe" <alibuda@...ux.alibaba.com>, Tony Lu <tonylu@...ux.alibaba.com>, 
 Wen Gu <guwen@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org, 
 Michal Luczaj <mhal@...x.co>
Subject: [PATCH net-next v2 0/9] net: Remove unused function parameters in
 skbuff.c

Couple of cleanup patches to get rid of unused function parameters around
skbuff.c, plus little things spotted along the way.

Offshoot of my question in [1], but way more contained. Found by adding
"-Wunused-parameter -Wno-error" to KBUILD_CFLAGS and grepping for specific
skbuff.c warnings.

[1]: https://lore.kernel.org/netdev/972af569-0c90-4585-9e1f-f2266dab6ec6@rbox.co/

Signed-off-by: Michal Luczaj <mhal@...x.co>
---
Changes in v2:
- Fix typos in commit messages
- Remove one more unused parameter in skbuff.c (patch 9)
- Collect R-b, add a one-line cleanup of smc_rx_splice() (patch 7) [Simon]
- Link to v1: https://lore.kernel.org/r/20250624-splice-drop-unused-v1-0-cf641a676d04@rbox.co

---
Michal Luczaj (9):
      net: splice: Drop unused @pipe
      net: splice: Drop unused @flags
      tcp: Drop tcp_splice_state::flags
      af_unix: Drop unix_stream_read_state::splice_flags
      net: splice: Drop unused @gfp
      net: splice: Drop nr_pages_max initialization
      net/smc: Drop nr_pages_max initialization
      net: skbuff: Drop unused @skb
      net: skbuff: Drop unused @skb

 .../chelsio/inline_crypto/chtls/chtls_io.c         |  3 +-
 include/linux/skbuff.h                             |  5 ++-
 net/core/skbuff.c                                  | 37 ++++++++--------------
 net/ipv4/ip_output.c                               |  3 +-
 net/ipv4/tcp.c                                     |  7 ++--
 net/ipv6/ip6_output.c                              |  3 +-
 net/kcm/kcmsock.c                                  |  5 ++-
 net/smc/smc_rx.c                                   |  1 -
 net/tls/tls_sw.c                                   |  2 +-
 net/unix/af_unix.c                                 |  7 ++--
 10 files changed, 26 insertions(+), 47 deletions(-)
---
base-commit: a9b24b3583ae1da7dbda031f141264f2da260219
change-id: 20250618-splice-drop-unused-0e4ea8a12681

Best regards,
-- 
Michal Luczaj <mhal@...x.co>