linux-kernel - Re: [PATCHv2 01/12] x86/tdx: Consolidate TDX error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <013baf358a7cfb958df6e44df0ccd518470a4d39.camel@intel.com>
Date: Thu, 26 Jun 2025 00:05:53 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "Hansen, Dave"
	<dave.hansen@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "Gao, Chao" <chao.gao@...el.com>, "Edgecombe, Rick P"
	<rick.p.edgecombe@...el.com>, "bp@...en8.de" <bp@...en8.de>, "x86@...nel.org"
	<x86@...nel.org>, "mingo@...hat.com" <mingo@...hat.com>, "Zhao, Yan Y"
	<yan.y.zhao@...el.com>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-coco@...ts.linux.dev"
	<linux-coco@...ts.linux.dev>, "Yamahata, Isaku" <isaku.yamahata@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 01/12] x86/tdx: Consolidate TDX error handling

On Wed, 2025-06-25 at 10:58 -0700, Hansen, Dave wrote:
> > -/*
> > - * TDX module SEAMCALL leaf function error codes
> > - */
> > -#define TDX_SUCCESS		0ULL
> > -#define TDX_RND_NO_ENTROPY	0x8000020300000000ULL
> 
> Kai, you were responsible for this nugget. What do you think of this patch?

(sorry for getting into this late)

I am 100% with consolidating TDX definitions across KVM and the core kernel,
so thanks Kirill for doing this.

But as you suggested, I think it's better to split this patch into two:

 - One patch to just move error code from tdx_error.h in KVM and TDX guest
code to <asm/tdx_error.h>.
 - One patch to further introduce those helpers (tdx_rnd_no_entropy() etc)
and actually use them in the code.

It will be easier to review anyway.