linux-kernel - Re: [PATCH 1/3] i2c: stm32: fix the device used for the DMA map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626084356.GB348766@gnbcxd0016.gnb.st.com>
Date: Thu, 26 Jun 2025 10:43:56 +0200
From: Alain Volmat <alain.volmat@...s.st.com>
To: Clément Le Goffic <clement.legoffic@...s.st.com>
CC: Pierre-Yves MORDRET <pierre-yves.mordret@...s.st.com>,
        Andi Shyti
	<andi.shyti@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Sumit Semwal
	<sumit.semwal@...aro.org>,
        Christian König
	<christian.koenig@....com>,
        M'boumba Cedric Madianga
	<cedric.madianga@...il.com>,
        Wolfram Sang <wsa@...nel.org>,
        "Pierre-Yves
 MORDRET" <pierre-yves.mordret@...com>,
        <linux-i2c@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH 1/3] i2c: stm32: fix the device used for the DMA map

Hi Clément,

Oups, I was too fast.

there might be another place to correct in the driver, dma_unmap_single
within the error handling of the function stm32_i2c_prep_dma_xfer.

   err:
            dma_unmap_single(chan_dev, dma->dma_buf, dma->dma_len,
                             dma->dma_data_dir);

Could you also correct this one as well ?

Alain


On Thu, Jun 26, 2025 at 10:37:51AM +0200, Alain Volmat wrote:
> Hi Clément,
> 
> On Mon, Jun 16, 2025 at 10:53:54AM +0200, Clément Le Goffic wrote:
> > If the DMA mapping failed, it produced an error log with the wrong
> > device name:
> > "stm32-dma3 40400000.dma-controller: rejecting DMA map of vmalloc memory"
> > Fix this issue by replacing the dev with the I2C dev.
> 
> Indeed, nice catch ! Thanks a lot !
> 
> > 
> > Fixes: bb8822cbbc53 ("i2c: i2c-stm32: Add generic DMA API")
> > Signed-off-by: Clément Le Goffic <clement.legoffic@...s.st.com>
> > ---
> >  drivers/i2c/busses/i2c-stm32.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-stm32.c b/drivers/i2c/busses/i2c-stm32.c
> > index 157c64e27d0b..5e0b31aed774 100644
> > --- a/drivers/i2c/busses/i2c-stm32.c
> > +++ b/drivers/i2c/busses/i2c-stm32.c
> > @@ -118,7 +118,7 @@ int stm32_i2c_prep_dma_xfer(struct device *dev, struct stm32_i2c_dma *dma,
> >  	dma->dma_len = len;
> >  	chan_dev = dma->chan_using->device->dev;
> >  
> > -	dma->dma_buf = dma_map_single(chan_dev, buf, dma->dma_len,
> > +	dma->dma_buf = dma_map_single(dev, buf, dma->dma_len,
> >  				      dma->dma_data_dir);
> >  	if (dma_mapping_error(chan_dev, dma->dma_buf)) {
> >  		dev_err(dev, "DMA mapping failed\n");
> > 
> > -- 
> > 2.43.0
> >
> 
> Acked-by: Alain Volmat <alain.volmat@...s.st.com>
> 
> Regards,
> Alain