linux-kernel - Re: [PATCH net-next v2] net/mlx5e: Fix error handling in RQ memory model registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250626090753.GU1562@horms.kernel.org>
Date: Thu, 26 Jun 2025 10:07:53 +0100
From: Simon Horman <horms@...nel.org>
To: Fushuai Wang <wangfushuai@...du.com>
Cc: saeedm@...dia.com, tariqt@...dia.com, leon@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zhu Yanjun <yanjun.zhu@...ux.dev>,
	Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next v2] net/mlx5e: Fix error handling in RQ memory
 model registration

On Thu, Jun 26, 2025 at 01:30:03PM +0800, Fushuai Wang wrote:
> Currently when xdp_rxq_info_reg_mem_model() fails in the XSK path, the
> error handling incorrectly jumps to err_destroy_page_pool. While this
> may not cause errors, we should make it jump to the correct location.
> 
> Signed-off-by: Fushuai Wang <wangfushuai@...du.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> Acked-by: Dragos Tatulea <dtatulea@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks for rebasing.
This version applies cleanly and otherwise LGTM.