linux-kernel - Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a5849d2-2e75-4d04-ad24-bccbed6ed666@kernel.org>
Date: Thu, 26 Jun 2025 12:01:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 vincent.knecht@...loo.org, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 André Apitzsch <git@...tzsch.eu>,
 phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

On 06/06/2025 12:46, Vladimir Zapolskiy wrote:
> Hello Vincent.
> 
> On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote:
>> From: Vincent Knecht <vincent.knecht@...loo.org>
>>
>> Add bindings for qcom,msm8939-camss in order to support the camera
>> subsystem for MSM8939.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
>> ---
>>   .../bindings/media/qcom,msm8939-camss.yaml         | 254 +++++++++++++++++++++
>>   1 file changed, 254 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..59bf16888a8235495a2080e512ce179583bcd25d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml
>> @@ -0,0 +1,254 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/qcom,msm8939-camss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm MSM8939 Camera Subsystem (CAMSS)
>> +
>> +maintainers:
>> +  - Vincent Knecht <vincent.knecht@...loo.org>
>> +
>> +description:
>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,msm8939-camss
>> +
>> +  reg:
>> +    maxItems: 11
>> +
>> +  reg-names:
>> +    items:
>> +      - const: csid0
>> +      - const: csid1
>> +      - const: csid2
>> +      - const: csiphy0
>> +      - const: csiphy0_clk_mux
>> +      - const: csiphy1
>> +      - const: csiphy1_clk_mux
>> +      - const: csi_clk_mux
>> +      - const: ispif
>> +      - const: vfe0
>> +      - const: vfe0_vbif
> 
> Please sort the list alphanumerically, accorting to the ASCII character set
> the underscore symbol precedes lower case letters.


This messes up with preferred style, as I described multiple times now.
You need to stop this sorting madness - asking people to sort values by
some own rules.

Best regards,
Krzysztof