linux-kernel - Re: PATCH] i2c: stm32f7: Use str_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626112428.GA350099@gnbcxd0016.gnb.st.com>
Date: Thu, 26 Jun 2025 13:24:28 +0200
From: Alain Volmat <alain.volmat@...s.st.com>
To: <long.yunjian@....com.cn>
CC: <pierre-yves.mordret@...s.st.com>, <andi.shyti@...nel.org>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
        <linux-i2c@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <mou.yi@....com.cn>, <xu.lifeng1@....com.cn>,
        <ouyang.maochun@....com.cn>, <fang.yumeng@....com.cn>
Subject: Re: PATCH] i2c: stm32f7: Use str_on_off() helper

Hi,

thank you for your patch.

On Mon, Jun 23, 2025 at 08:31:44PM +0800, long.yunjian@....com.cn wrote:
> From: Yumeng Fang <fang.yumeng@....com.cn>
> 
> Remove hard-coded strings by using the str_on_off() helper.
> 
> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index e4aaeb2262d0..ef15475a7ee1 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -34,6 +34,7 @@
>  #include <linux/regmap.h>
>  #include <linux/reset.h>
>  #include <linux/slab.h>
> +#include <linux/string_choices.h>
> 
>  #include "i2c-stm32.h"
> 
> @@ -722,7 +723,7 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev,
>  	dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n",
>  		setup->rise_time, setup->fall_time);
>  	dev_dbg(i2c_dev->dev, "I2C Analog Filter(%s), DNF(%i)\n",
> -		(i2c_dev->analog_filter ? "On" : "Off"), i2c_dev->dnf);
> +		str_on_off(i2c_dev->analog_filter), i2c_dev->dnf);
> 
>  	i2c_dev->bus_rate = setup->speed_freq;
> 

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Regards,
Alain
> -- 
> 2.25.1