linux-kernel - RE: [PATCH] mce: include cmci during intel feature clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71349D25CD9C67B65DC5B849897AA@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Thu, 26 Jun 2025 02:18:41 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: Borislav Petkov <bp@...en8.de>, JP Kobryn <inwardvessel@...il.com>
CC: "Luck, Tony" <tony.luck@...el.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "hpa@...or.com"
	<hpa@...or.com>, "aijay@...a.com" <aijay@...a.com>, "x86@...nel.org"
	<x86@...nel.org>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-team@...a.com" <kernel-team@...a.com>
Subject: RE: [PATCH] mce: include cmci during intel feature clearing

Hi JP,

> [...]
> > Just focusing on the feature pertaining to the root cause of the kexec
> > issue, there would be a benefit if we additionally cleared the CMCI
> > feature within this routine - the banks would be free for acquisition
> > on the boot up side of a kexec. This patch adds the call to clear CMCI
> > to this intel routine.
> 
> Please:
> 
>  - shorten this commit message - there really is no need to explain in such
>    detail that mcheck_cpu_clear() has simply forgotten to clear CMCI banks
>    too.
> 
>  - run it through a spellchecker
> 
>  - drop all personal pronouns
> 
>  - write it in imperative tone
> 
> Some hints:
> 
> Section "2) Describe your changes" in
> Documentation/process/submitting-patches.rst for more details.
> 
> Also, see section "Changelog" in
> Documentation/process/maintainer-tip.rst
> 

Please address Boris' comments, other than that

    Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>