linux-kernel - Re: [PATCH v11 13/14] perf/x86: Rename and move get_segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626081352.30b360f8@gandalf.local.home>
Date: Thu, 26 Jun 2025 08:13:52 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bpf@...r.kernel.org, x86@...nel.org, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Josh Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>, Jiri Olsa <jolsa@...nel.org>, Namhyung Kim
 <namhyung@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Andrii
 Nakryiko <andrii@...nel.org>, Indu Bhagat <indu.bhagat@...cle.com>, "Jose
 E. Marchesi" <jemarch@....org>, Beau Belgrave <beaub@...ux.microsoft.com>,
 Jens Remus <jremus@...ux.ibm.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>,
 Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v11 13/14] perf/x86: Rename and move get_segment_base()
 and make it global

On Thu, 26 Jun 2025 10:44:40 +0200
Ingo Molnar <mingo@...nel.org> wrote:

> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > From: Josh Poimboeuf <jpoimboe@...nel.org>
> > 
> > get_segment_base() will be used by the unwind_user code, so make it
> > global and rename it to segment_base_address() so it doesn't conflict with
> > a KVM function of the same name.  
> 
> So if you make an x86-internal helper function global, please prefix it 
> with x86_ or so:
> 
> 	unsigned long x86_get_segment_base(unsigned int segment)
> 
> Keeping the _get name also keeps it within the nomenclature of the 
> general segment descriptor API family:
> 
> 	get_desc_base()
> 	set_desc_base()
> 	get_desc_limit()
> 	set_desc_limit()
>   [x86_]get_segment_base()

Sounds good.

> 
> > Also add a lockdep_assert_irqs_disabled() to make sure it's always 
> > called with interrupts disabled.  
> 
> Please make this a separate patch, this change gets hidden in the noise 
> of the function movement and renaming otherwise, plus it also makes the 
> title false and misleading:
> 
>    perf/x86: Rename and move get_segment_base() and make it global
> 

I'll break it up.

Thanks for the review!

-- Steve