linux-kernel - Re: [PATCH 00/15] ASoC/soundwire: Realtek codecs: wait codec init in hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f95f6777-7445-46dc-be53-b3ae5594bf39@linux.dev>
Date: Thu, 26 Jun 2025 14:19:18 +0200
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>
To: Bard Liao <yung-chuan.liao@...ux.intel.com>, broonie@...nel.org,
 tiwai@...e.de, linux-sound@...r.kernel.org, vkoul@...nel.org
Cc: vinod.koul@...aro.org, linux-kernel@...r.kernel.org, bard.liao@...el.com
Subject: Re: [PATCH 00/15] ASoC/soundwire: Realtek codecs: wait codec init in
 hw_params

Hi Bard,

> The current code waits for the codec initialization in the resume
> callback. It could cause the resume takes a long time while waiting for
> the codec being attached and initialized. Move the waiting to the
> hw_params callback when the driver really needs it and shorten the
> resume time.
> The change is mainly on the ASoC tree. Let's go through the ASoC tree.

While I certainly understand the desire to make the resume time lower, is this approach desirable in all cases?

My main worry is this: not all functionality in a codec is related to the hw_params. One counter example would be register settings related to jack detection. You would want the regmap settings to be correctly applied in hardware registers even in the absence of any streaming request, no?

The other weird thing is that historically the codec initialization was never on the critical path, it was several orders of magnitude faster than the controller. It wouldn't hurt to provide broad-brush information on what a 'long' time means for a codec resume, so that we can really see the pros/cons of moving all the regmap initialization.

Another open is that SDCA defines the notion of 'blind writes' which would typically be done during a resume if context was lost. If we start moving some parts of the initialization to the hw_params and others remain in the resume flow, that will quickly lead to complexity in managing configuration.

The last point is that this is a change for Realtek codecs only, would other drivers for other vendors require this change? And if I may ask is there any merit in speeding-up resume times even for 'legacy' non-sdca parts?

> Bard Liao (15):
>   soundwire: add sdw_slave_wait_for_initialization helper
>   ASoC: rt722: wait codec init in hw_params
>   ASoC: rt712: wait codec init in hw_params
>   ASoC: rt1320: wait codec init in hw_params
>   ASoC: rt721: wait codec init in hw_params
>   ASoC: rt715-sdca: wait codec init in hw_params
>   ASoC: rt711-sdca: wait codec init in hw_params
>   ASoC: rt711: wait codec init in hw_params
>   ASoC: rt715: wait codec init in hw_params
>   ASoC: rt700: wait codec init in hw_params
>   ASoC: rt1316: wait codec init in hw_params
>   ASoC: rt1318: wait codec init in hw_params
>   ASoC: rt1308: wait codec init in hw_params
>   ASoC: rt5682: wait codec init in hw_params
>   ASoC: rt1017: wait codec init in hw_params
> 
>  drivers/soundwire/slave.c          | 17 ++++++++++++++
>  include/linux/soundwire/sdw.h      |  1 +
>  sound/soc/codecs/rt1017-sdca-sdw.c | 32 ++++++++++++++++----------
>  sound/soc/codecs/rt1308-sdw.c      | 32 ++++++++++++++++----------
>  sound/soc/codecs/rt1316-sdw.c      | 32 ++++++++++++++++----------
>  sound/soc/codecs/rt1318-sdw.c      | 30 ++++++++++++++++--------
>  sound/soc/codecs/rt1320-sdw.c      | 32 ++++++++++++++++++--------
>  sound/soc/codecs/rt5682-sdw.c      | 29 +++++++++++++++--------
>  sound/soc/codecs/rt700-sdw.c       | 27 ++++++++++++----------
>  sound/soc/codecs/rt700.c           |  6 +++++
>  sound/soc/codecs/rt711-sdca-sdw.c  | 28 ++++++++++++----------
>  sound/soc/codecs/rt711-sdca.c      |  6 +++++
>  sound/soc/codecs/rt711-sdw.c       | 26 +++++++++++++--------
>  sound/soc/codecs/rt711.c           |  6 +++++
>  sound/soc/codecs/rt712-sdca-sdw.c  | 28 ++++++++++++----------
>  sound/soc/codecs/rt712-sdca.c      |  6 +++++
>  sound/soc/codecs/rt715-sdca-sdw.c  | 37 ++++++++++++++++++++----------
>  sound/soc/codecs/rt715-sdca.c      |  6 +++++
>  sound/soc/codecs/rt715-sdw.c       | 27 ++++++++++++----------
>  sound/soc/codecs/rt715.c           |  6 +++++
>  sound/soc/codecs/rt721-sdca-sdw.c  | 29 ++++++++++++-----------
>  sound/soc/codecs/rt721-sdca.c      |  6 +++++
>  sound/soc/codecs/rt722-sdca-sdw.c  | 26 +++++++++++----------
>  sound/soc/codecs/rt722-sdca.c      |  6 +++++
>  24 files changed, 320 insertions(+), 161 deletions(-)
>