linux-kernel - Re: [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aF1FmEBzO1_-HOfD@shell.armlinux.org.uk>
Date: Thu, 26 Jun 2025 14:05:28 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Kamil Horák - 2N <kamilh@...s.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	krzk+dt@...nel.org, conor+dt@...nel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	f.fainelli@...il.com, robh@...nel.org, andrew+netdev@...n.ch
Subject: Re: [PATCH 3/3] net: phy: bcm54811: Fix the PHY initialization

On Thu, Jun 26, 2025 at 01:56:19PM +0200, Kamil Horák - 2N wrote:
> +		/* BCM54811 is not capable of LDS but the corresponding bit
> +		 * in LRESR is set to 1 and marked "Ignore" in the datasheet.
> +		 * So we must read the bcm54811 as unable to auto-negotiate
> +		 * in BroadR-Reach mode.
> +		 */
> +		aneg = (BRCM_PHY_MODEL(phydev) != PHY_ID_BCM54811) ?
> +			(val & LRESR_LDSABILITY) : 0;

Wouldn't:

		if (BRCM_PHY_MODEL(phydev) == PHY_ID_BCM54811)
			aneg = 0;
		else
			aneg = val & LRESR_LDSABILITY;

be more readable?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!