linux-kernel - Re: [PATCH] usb: gadget: u_serial: remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81a704b2-56c4-4ea7-bcce-831ad2e4d070@suswa.mountain>
Date: Thu, 26 Jun 2025 16:21:40 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Prashanth K <prashanth.k@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lianqin Hu <hulianqin@...o.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Jeff Johnson <jeff.johnson@....qualcomm.com>,
	Michael Walle <mwalle@...nel.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: u_serial: remove some dead code

On Thu, Jun 26, 2025 at 11:53:05AM +0530, Prashanth K wrote:
> 
> 
> On 6/25/2025 8:51 PM, Dan Carpenter wrote:
> > There is no need to check if "port" is NULL.  We already verified that it
> > is non-NULL.  It's a stack variable and can't be modified by a different
> > thread.  Delete this dead code.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> 
> Perhaps you could add Closes and Fixes tag, but its up to you.

Fixes is only for bugs.  If I put a Closes tag, then I'd have to give
myself reported by credit as well which is just being greedy for tags. :P

regards,
dan carpenter