linux-kernel - Re: [RFC PATCH 12/20] nvdimm/namespace_label: Skip region label during namespace creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1931444790.41750944183140.JavaMail.epsvc@epcpadp2new>
Date: Thu, 26 Jun 2025 15:32:10 +0530
From: Neeraj Kumar <s.neeraj@...sung.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: dan.j.williams@...el.com, dave@...olabs.net, dave.jiang@...el.com,
	alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
	a.manzanares@...sung.com, nifan.cxl@...il.com, anisa.su@...sung.com,
	vishak.g@...sung.com, krish.reddy@...sung.com, arun.george@...sung.com,
	alok.rathore@...sung.com, neeraj.kernel@...il.com,
	linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
	nvdimm@...ts.linux.dev, gost.dev@...sung.com, cpgs@...sung.com
Subject: Re: [RFC PATCH 12/20] nvdimm/namespace_label: Skip region label
 during namespace creation

On 23/06/25 10:17AM, Jonathan Cameron wrote:
>On Tue, 17 Jun 2025 18:09:36 +0530
>Neeraj Kumar <s.neeraj@...sung.com> wrote:
>
>> During namespace creation skip presence of region label if present.
>> Also preserve region label into labels list if present.
>>
>> Signed-off-by: Neeraj Kumar <s.neeraj@...sung.com>
>> ---
>>  drivers/nvdimm/namespace_devs.c | 48 +++++++++++++++++++++++++++++----
>>  1 file changed, 43 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
>> index b081661b7aaa..ca8f8546170c 100644
>> --- a/drivers/nvdimm/namespace_devs.c
>> +++ b/drivers/nvdimm/namespace_devs.c
>> @@ -1976,6 +1976,10 @@ static struct device **scan_labels(struct nd_region *nd_region)
>>  		if (!nd_label)
>>  			continue;
>>
>> +		/* skip region labels if present */
>> +		if (is_region_label(ndd, nd_label))
>> +			continue;
>> +
>>  		/* skip labels that describe extents outside of the region */
>>  		if (nsl_get_dpa(ndd, &nd_label->ns_label) < nd_mapping->start ||
>>  		    nsl_get_dpa(ndd, &nd_label->ns_label) > map_end)
>> @@ -2014,9 +2018,29 @@ static struct device **scan_labels(struct nd_region *nd_region)
>>
>>  	if (count == 0) {
>>  		struct nd_namespace_pmem *nspm;
>> +		for (i = 0; i < nd_region->ndr_mappings; i++) {
>> +			struct nd_label_ent *le, *e;
>> +			LIST_HEAD(list);
>>
>> -		/* Publish a zero-sized namespace for userspace to configure. */
>> -		nd_mapping_free_labels(nd_mapping);
>> +			nd_mapping = &nd_region->mapping[i];
>> +			if (list_empty(&nd_mapping->labels))
>> +				continue;
>> +
>> +			list_for_each_entry_safe(le, e, &nd_mapping->labels,
>> +						 list) {
>> +				struct nd_lsa_label *nd_label = le->label;
>> +
>> +				/* preserve region labels if present */
>> +				if (is_region_label(ndd, nd_label))
>> +					list_move_tail(&le->list, &list);
>> +			}
>> +
>> +			/* Publish a zero-sized namespace for userspace
>
>Comment syntax as before looks to be inconsistent with file.
>

Thanks, Will update it everywhere its inconsistent.

>> +			 * to configure.
>> +			 */
>> +			nd_mapping_free_labels(nd_mapping);
>> +			list_splice_init(&list, &nd_mapping->labels);
>> +		}
>>  		nspm = kzalloc(sizeof(*nspm), GFP_KERNEL);
>>  		if (!nspm)
>>  			goto err;
>> @@ -2028,7 +2052,7 @@ static struct device **scan_labels(struct nd_region *nd_region)
>>  	} else if (is_memory(&nd_region->dev)) {
>>  		/* clean unselected labels */
>>  		for (i = 0; i < nd_region->ndr_mappings; i++) {
>> -			struct list_head *l, *e;
>> +			struct nd_label_ent *le, *e;
>>  			LIST_HEAD(list);
>>  			int j;
>>
>> @@ -2039,10 +2063,24 @@ static struct device **scan_labels(struct nd_region *nd_region)
>>  			}
>>
>>  			j = count;
>> -			list_for_each_safe(l, e, &nd_mapping->labels) {
>> +			list_for_each_entry_safe(le, e, &nd_mapping->labels,
>> +						 list) {
>> +				struct nd_lsa_label *nd_label = le->label;
>> +
>> +				/* preserve region labels */
>> +				if (is_region_label(ndd, nd_label)) {
>> +					list_move_tail(&le->list, &list);
>> +					continue;
>> +				}
>> +
>> +				/* Once preserving selected ns label done
>Comment syntax.

Sure, Will fix it up

>> +				 * break out of loop
>> +				 */
>>  				if (!j--)
>>  					break;
>> -				list_move_tail(l, &list);
>> +
>> +				/* preserve selected ns label */
>> +				list_move_tail(&le->list, &list);
>>  			}
>>  			nd_mapping_free_labels(nd_mapping);
>>  			list_splice_init(&list, &nd_mapping->labels);
>