linux-kernel - Re: [PATCH v2] fs/proc/vmcore: a few cleanups for vmcore_add_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e891bba8-9f67-47c6-8f84-a62abe35f837@suswa.mountain>
Date: Thu, 26 Jun 2025 16:24:43 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Su Hui <suhui@...china.com>
Cc: akpm@...ux-foundation.org, bhe@...hat.com, vgoyal@...hat.com,
	dyoung@...hat.com, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] fs/proc/vmcore: a few cleanups for
 vmcore_add_device_dump

On Thu, Jun 26, 2025 at 06:54:41PM +0800, Su Hui wrote:
> There are two cleanups for vmcore_add_device_dump(). Return -ENOMEM
> directly rather than goto the label to simplify the code. Using
> scoped_guard() to simplify the lock/unlock code.
> 
> Signed-off-by: Su Hui <suhui@...china.com>
> ---

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter