linux-kernel - Re: [PATCH v2] block: fix false warning in bdev_count_inflight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF1MOxsOm2tcc0Ct@infradead.org>
Date: Thu, 26 Jun 2025 06:33:47 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai3@...wei.com>
Cc: axboe@...nel.dk, hare@...e.de, hch@...radead.org,
	john.g.garry@...cle.com, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, yi.zhang@...hat.com,
	calvin@...nvd.org, david@...morbit.com, yukuai1@...weicloud.com,
	yi.zhang@...wei.com, yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH v2] block: fix false warning in bdev_count_inflight_rw()

On Thu, Jun 26, 2025 at 07:57:43PM +0800, Yu Kuai wrote:
>  static void bdev_count_inflight_rw(struct block_device *part,
>  		unsigned int inflight[2], bool mq_driver)

Why not pass the inflight arguments as signed? (and split it for
reads and writes as you did below)

Anyway, I think this is good enough to get a fix queued up ASAP,
but we can probably clean it up incrementally:

Reviewed-by: Christoph Hellwig <hch@....de>