linux-kernel - Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250626-rigorous-gentle-foxhound-d864c1-mkl@pengutronix.de>
Date: Thu, 26 Jun 2025 15:57:14 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Chandrasekar Ramakrishnan <rcsekar@...sung.com>, Fengguang Wu <fengguang.wu@...el.com>, 
	Varka Bhadram <varkabhadram@...il.com>, Dong Aisheng <b29396@...escale.com>
Subject: Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx

On 26.06.2025 13:45:09, Sean Nyekjaer wrote:
> Hi,
> 
> On Sat, Jun 21, 2025 at 11:13:33AM +0100, Vincent Mailhol wrote:
> > On 20/06/2025 at 19:00, Sean Nyekjaer wrote:
> > > Wrap the "msg lost in rxf0" error in m_can_handle_lost_msg() with
> > > a call to net_ratelimit() to prevent flooding the kernel log
> > > with repeated error messages.
> > 
> > Note that another solution is to simply remove the error message. The users can
> > use the CAN error frames or the netstasts instead to see if lost messages occurred.
> > 
> > That said, I am OK with your proposed patch. See above comment as a simple FYI.
> 
> I'm up for both solutions :)
> 
> @Marc what would you prefer?

If it is my call, then make it a netdev_dbg();

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)