[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a25733d7-535c-44b8-973c-0bc0c99047c3@roeck-us.net>
Date: Fri, 27 Jun 2025 06:28:58 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: jesse huang <jesse.huang@...twell.com.tw>
Cc: hansg@...nel.org, ilpo.jarvinen@...ux.intel.com, jdelvare@...e.com,
linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-hwmon@...r.kernel.org
Subject: Re: [PATCH 2/2] platform/x86: portwell-ec: Add hwmon support for
voltage and temperature
On Fri, Jun 27, 2025 at 05:15:01PM +0800, jesse huang wrote:
> Integrates Vcore, VDIMM, 3.3V, 5V, 12V voltage and system temperature
> monitoring into the driver via the hwmon subsystem, enabling
> standardized reporting via tools like lm-sensors.
>
> Signed-off-by: Yen-Chi Huang <jesse.huang@...twell.com.tw>
> ---
> drivers/platform/x86/portwell-ec.c | 188 ++++++++++++++++++++++++++++-
> 1 file changed, 186 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
> index a68522aaa3fa..79597b4b5559 100644
> --- a/drivers/platform/x86/portwell-ec.c
> +++ b/drivers/platform/x86/portwell-ec.c
> @@ -33,6 +33,10 @@
> #include <linux/sizes.h>
> #include <linux/string.h>
> #include <linux/watchdog.h>
> +#include <linux/hwmon.h>
> +#include <linux/hwmon-sysfs.h>
> +#include <linux/hwmon-vid.h>
Two unnecessary include files.
Guenter
Powered by blists - more mailing lists