linux-kernel - Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85c3658fdfa90636caac3b3fce295915@disroot.org>
Date: Fri, 27 Jun 2025 13:44:17 +0000
From: Kaustabh Chakraborty <kauschluss@...root.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Inki Dae <inki.dae@...sung.com>, Seung-Woo Kim <sw0312.kim@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Alim Akhtar <alim.akhtar@...sung.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring
 <robh@...nel.org>, Conor Dooley <conor@...nel.org>, Ajay Kumar
 <ajaykumar.rs@...sung.com>, Akshu Agrawal <akshua@...il.com>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add
 properties for iommus and ports

On 2025-06-27 07:50, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 12:50:28AM +0530, Kaustabh Chakraborty wrote:
>> Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware:
>> - May optionally require an IOMMU to initialize a display region.
>> - May require a port connection to another block, say an MIC or a DSI
>>   master.
>> 
>> Document these bindings in the devicetree schema.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
>> ---
>>  .../bindings/display/samsung/samsung,exynos7-decon.yaml           | 8 
>> ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml 
>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
>> index 
>> 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b 
>> 100644
>> --- 
>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
>> +++ 
>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
>> @@ -80,6 +80,14 @@ properties:
>>        - const: vsync
>>        - const: lcd_sys
>> 
>> +  iommus:
>> +    maxItems: 1
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    description:
>> +      Contains a port which is connected to mic or dsim node.
> 
> You need to list and describe the ports.

-    description:
-      Contains a port which is connected to mic or dsim node.
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/properties/port
+        description:
+          Input port which is connected to either a Mobile Image
+          Compressor (MIC) or a DSI Master device.

I assume you want something like this?
Is the formatting correct? Should there be a space between
ports:$ref and ports:properties?

> 
> Best regards,
> Krzysztof