linux-kernel - Re: [PATCH v4 01/10] coresight: tmc: Support atclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627135940.GR794930@e132581.arm.com>
Date: Fri, 27 Jun 2025 14:59:40 +0100
From: Leo Yan <leo.yan@....com>
To: Yeoreum Yun <yeoreum.yun@....com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>,
	Mike Leach <mike.leach@...aro.org>,
	James Clark <james.clark@...aro.org>,
	Anshuman Khandual <anshuman.khandual@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 01/10] coresight: tmc: Support atclk

Hi Levi,

On Fri, Jun 27, 2025 at 02:49:19PM +0100, Yeoreum Yun wrote:
> >
> > > @@ -789,6 +789,10 @@ static int __tmc_probe(struct device *dev, struct resource *res)
> > >  	struct coresight_desc desc = { 0 };
> > >  	struct coresight_dev_list *dev_list = NULL;
> > >
> > > +	drvdata->atclk = devm_clk_get_optional_enabled(dev, "atclk");
> > > +	if (IS_ERR(drvdata->atclk))
> > > +		return PTR_ERR(drvdata->atclk);
> > > +
> > >  	ret = -ENOMEM;
> > >
> >
> > Just another quetion.
> >
> > If this function is called from tmc_platform_probe() and failed,
> > should it call the clk_put() for drvdata->pclk when it failed?
> 
> Sorry, I missed the Patch #7.

No worries.

devm_clk_release() is a registered callback used by the device model
layer to release resources. The clock will be released in the flow:

  devm_clk_release()
    `> clk_put()
         `> free_clk()

Thanks,
Leo