linux-kernel - Re: [PATCH] block: mtip32xx: Fix usage of dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF6l4STJBU7nXYS1@smile.fi.intel.com>
Date: Fri, 27 Jun 2025 17:08:33 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Jens Axboe <axboe@...nel.dk>, Philipp Stanner <phasta@...nel.org>,
	Anuj Gupta <anuj20.g@...sung.com>,
	Al Viro <viro@...iv.linux.org.uk>, Li Zetao <lizetao1@...wei.com>,
	Asai Thambi S P <asamymuthupa@...ron.com>,
	Sam Bradshaw <sbradshaw@...ron.com>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Fix usage of dma_map_sg()

On Fri, Jun 27, 2025 at 02:11:19PM +0200, Thomas Fourier wrote:
> The dma_map_sg() can fail and, in case of failure, returns 0.  If it
> fails, mtip_hw_submit_io() returns an error.
> 
> The dma_unmap_sg() requires the nents parameter to be the same as the
> one passed to dma_map_sg(). This patch saves the nents in
> command->scatter_ents.

I don't know why I'm in Cc list here, but FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
with a caveat that I am not an expert at all in these areas. Code
just look okay and doing sane things.

-- 
With Best Regards,
Andy Shevchenko