linux-kernel - Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF6nEOVhLURyf616@smile.fi.intel.com>
Date: Fri, 27 Jun 2025 17:13:36 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	Raag Jadav <raag.jadav@...el.com>,
	"Tauro, Riana" <riana.tauro@...el.com>,
	"Adatrao, Srinivasa" <srinivasa.adatrao@...el.com>,
	"Michael J. Ruhl" <michael.j.ruhl@...el.com>,
	intel-xe@...ts.freedesktop.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] i2c: designware: Add quirk for Intel Xe

On Fri, Jun 27, 2025 at 04:53:11PM +0300, Heikki Krogerus wrote:
> The regmap is coming from the parent also in case of Xe
> GPUs. Reusing the Wangxun quirk for that.

...

>  static int dw_i2c_plat_probe(struct platform_device *pdev)
>  {
> +	u32 flags = (uintptr_t)device_get_match_data(&pdev->dev);

> -	dev->flags = (uintptr_t)device_get_match_data(device);
>  	if (device_property_present(device, "wx,i2c-snps-model"))
> -		dev->flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
> +		flags = MODEL_WANGXUN_SP | ACCESS_POLLING;
>  
>  	dev->dev = device;
>  	dev->irq = irq;
> +	dev->flags = flags;

Maybe I'm missing something, but why do we need these (above) changes?


-- 
With Best Regards,
Andy Shevchenko