linux-kernel - RE: [PATCH] drm/amdgpu: Use str_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5144C5766F6D12CE13206613F745A@BL1PR12MB5144.namprd12.prod.outlook.com>
Date: Fri, 27 Jun 2025 14:48:45 +0000
From: "Deucher, Alexander" <Alexander.Deucher@....com>
To: "long.yunjian@....com.cn" <long.yunjian@....com.cn>
CC: "Koenig, Christian" <Christian.Koenig@....com>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>, "Zhang, Hawking"
	<Hawking.Zhang@....com>, "Wang, Yang(Kevin)" <KevinYang.Wang@....com>, "Liu,
 Xiang(Dean)" <Xiang.Liu@....com>, "Zhou1, Tao" <Tao.Zhou1@....com>,
	"yanzhen@...o.com" <yanzhen@...o.com>, "fang.yumeng@....com.cn"
	<fang.yumeng@....com.cn>, "amd-gfx@...ts.freedesktop.org"
	<amd-gfx@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "xu.lifeng1@....com.cn"
	<xu.lifeng1@....com.cn>, "ouyang.maochun@....com.cn"
	<ouyang.maochun@....com.cn>, "mou.yi@....com.cn" <mou.yi@....com.cn>
Subject: RE: [PATCH] drm/amdgpu: Use str_on_off() helper

[Public]

> -----Original Message-----
> From: long.yunjian@....com.cn <long.yunjian@....com.cn>
> Sent: Friday, June 20, 2025 11:26 PM
> To: Deucher, Alexander <Alexander.Deucher@....com>
> Cc: Koenig, Christian <Christian.Koenig@....com>; airlied@...il.com;
> simona@...ll.ch; Zhang, Hawking <Hawking.Zhang@....com>; Wang,
> Yang(Kevin) <KevinYang.Wang@....com>; Liu, Xiang(Dean)
> <Xiang.Liu@....com>; Zhou1, Tao <Tao.Zhou1@....com>; yanzhen@...o.com;
> fang.yumeng@....com.cn; amd-gfx@...ts.freedesktop.org; dri-
> devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; xu.lifeng1@....com.cn;
> ouyang.maochun@....com.cn; mou.yi@....com.cn
> Subject: [PATCH] drm/amdgpu: Use str_on_off() helper
>
> From: Yumeng Fang <fang.yumeng@....com.cn>
>
> Remove hard-coded strings by using the str_on_off() helper.

I personally find that these helpers hurt readability.

Alex

>
> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 3 ++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> index cbc40cad581b..c3c88d8e1ce2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
> @@ -22,6 +22,7 @@
>   */
>
>  #include <linux/list.h>
> +#include <linux/string_choices.h>
>  #include "amdgpu.h"
>  #include "amdgpu_aca.h"
>  #include "amdgpu_ras.h"
> @@ -873,7 +874,7 @@ static int amdgpu_aca_smu_debug_mode_set(void *data,
> u64 val)
>       if (ret)
>               return ret;
>
> -     dev_info(adev->dev, "amdgpu set smu aca debug mode %s success\n", val
> ? "on" : "off");
> +     dev_info(adev->dev, "amdgpu set smu aca debug mode %s success\n",
> +str_on_off(val));
>
>       return 0;
>  }
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
> index 3ca03b5e0f91..81dcc7ebac3b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
> @@ -20,6 +20,7 @@
>   * OTHER DEALINGS IN THE SOFTWARE.
>   *
>   */
> +#include <linux/string_choices.h>
>  #include "amdgpu_ras.h"
>  #include "amdgpu.h"
>  #include "amdgpu_mca.h"
> @@ -519,7 +520,7 @@ static int amdgpu_mca_smu_debug_mode_set(void *data,
> u64 val)
>       if (ret)
>               return ret;
>
> -     dev_info(adev->dev, "amdgpu set smu mca debug mode %s success\n", val
> ? "on" : "off");
> +     dev_info(adev->dev, "amdgpu set smu mca debug mode %s success\n",
> +str_on_off(val));
>
>       return 0;
>  }
> --
> 2.25.1