linux-kernel - Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab1a39df178b68e2f1d61a537e0d567c@disroot.org>
Date: Fri, 27 Jun 2025 15:03:14 +0000
From: Kaustabh Chakraborty <kauschluss@...root.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Inki Dae <inki.dae@...sung.com>, Seung-Woo Kim <sw0312.kim@...sung.com>,
 Kyungmin Park <kyungmin.park@...sung.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Alim Akhtar <alim.akhtar@...sung.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring
 <robh@...nel.org>, Conor Dooley <conor@...nel.org>, Ajay Kumar
 <ajaykumar.rs@...sung.com>, Akshu Agrawal <akshua@...il.com>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add
 properties for iommus and ports

On 2025-06-27 14:44, Krzysztof Kozlowski wrote:
> On 27/06/2025 15:44, Kaustabh Chakraborty wrote:
>>>> a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
>>>> +++
>>>> b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
>>>> @@ -80,6 +80,14 @@ properties:
>>>>        - const: vsync
>>>>        - const: lcd_sys
>>>> 
>>>> +  iommus:
>>>> +    maxItems: 1
>>>> +
>>>> +  ports:
>>>> +    $ref: /schemas/graph.yaml#/properties/ports
>>>> +    description:
>>>> +      Contains a port which is connected to mic or dsim node.
>>> 
>>> You need to list and describe the ports.
>> 
>> -    description:
>> -      Contains a port which is connected to mic or dsim node.
>> +    properties:
>> +      port@0:
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          Input port which is connected to either a Mobile Image
>> +          Compressor (MIC) or a DSI Master device.
> 
> 
> If this is only one port, then just 'port' property, but I have doubts
> it should be one, because even you mentioned two - MIC could be the
> input and MIPI DSIM would be the output.

DECON is the first device in the pipeline. So it should only have
output.

It's either:
DECON -> DSIM -> panel
or
DECON -> MIC -> DSIM -> panel

Exynos7870 doesn't have MIC, but other SoCs may have one.

> 
> Maybe if the MIC is integral part, it would not have been an input, but
> then only 'port'.
> 
>> 
>> I assume you want something like this?
>> Is the formatting correct? Should there be a space between
>> ports:$ref and ports:properties?
> 
> Look at toshiba,tc358768.yaml or the simple-bridge (except you should
> name the input and output ports).

Okay, thanks!

Therefore this:

-    description:
-      Contains a port which is connected to mic or dsim node.
+
+    properties:
+      port:
+        $ref: /schemas/graph.yaml#/properties/port
+        description:
+          Output port which is connected to either a Mobile Image
+          Compressor (MIC) or a DSI Master device.

> 
> 
> 
> Best regards,
> Krzysztof