linux-kernel - Re: [PATCH net-next] sfc: siena: eliminate xdp_rxq_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a9be6e3-7533-4216-aecc-7261b4adf8af@gmail.com>
Date: Fri, 27 Jun 2025 16:34:14 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Fushuai Wang <wangfushuai@...du.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-net-drivers@....com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] sfc: siena: eliminate xdp_rxq_info_valid using
 XDP base API

On 26/06/2025 16:59, Fushuai Wang wrote:
> Commit eb9a36be7f3e ("sfc: perform XDP processing on received packets")
> and commit d48523cb88e0 ("sfc: Copy shared files needed for Siena
> (part 2)") use xdp_rxq_info_valid to track failures of xdp_rxq_info_reg().
> However, this driver-maintained state becomes redundant since the XDP
> framework already provides xdp_rxq_info_is_reg() for checking registration
> status.
> 
> Signed-off-by: Fushuai Wang <wangfushuai@...du.com>

Looks alright except that subject prefix is misleading as it sounds like
 it's just patching siena rather than both siena and ef10.
I'd suggest splitting this into two patches, one just touching the siena
 version with this title, the other with subject prefix just "sfc: ".