[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb2b64bc-a1b1-4486-9766-7c72ada7dd5a@baylibre.com>
Date: Fri, 27 Jun 2025 10:37:00 -0500
From: David Lechner <dlechner@...libre.com>
To: Kim Seer Paller <kimseer.paller@...log.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>, Nuno Sá
<nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad3530r: Fix incorrect masking for channels 4-7
in powerdown mode
On 6/26/25 3:38 AM, Kim Seer Paller wrote:
> In the current implementation of ad3530r_set_dac_powerdown() function,
> the macro AD3530R_OP_MODE_CHAN_MSK(chan->channel) is used to generate
> the bitmask for the operating mode of a specific channel. However, this
> macro does not account for channels 4-7, which map to the second
> register AD3530R_OUTPUT_OPERATING_MODE_1 for the 8 channeled device. As
> a result, the bitmask is incorrectly calculated for these channels,
> leading to improper configuration of the powerdown mode. Resolve this
> issue by adjusting the channel index for channels 4-7 by subtracting 4
> before applying the macro. This ensures that the correct bitmask is
> generated for the second register.
>
> Fixes: 93583174a3df ("iio: dac: ad3530r: Add driver for AD3530R and AD3531R")
> Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> ---
Reviewed-by: David Lechner <dlechner@...libre.com>
Powered by blists - more mailing lists