[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <68c06500-a776-4f56-8514-c180b23f7715@oss.qualcomm.com>
Date: Fri, 27 Jun 2025 17:54:31 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: srinivas.kandagatla@....qualcomm.com, vkoul@...nel.org, broonie@...nel.org
Cc: yung-chuan.liao@...ux.intel.com, pierre-louis.bossart@...ux.dev,
lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
krzysztof.kozlowski@...aro.org, linux-kernel@...r.kernel.org,
linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] soundwire: bus: add sdw_slave_get_current_bank helper
On 6/27/25 5:51 PM, srinivas.kandagatla@....qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>
> There has been 2 instances of this helper in codec drivers,
> it does not make sense to keep duplicating this part of code.
>
> Lets add a helper sdw_get_current_bank() for codec drivers to use it.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
> drivers/soundwire/bus.c | 7 +++++++
> include/linux/soundwire/sdw.h | 8 ++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 39aecd34c641..58306c515ccc 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -1363,6 +1363,13 @@ int sdw_slave_get_scale_index(struct sdw_slave *slave, u8 *base)
> }
> EXPORT_SYMBOL(sdw_slave_get_scale_index);
>
> +int sdw_slave_get_current_bank(struct sdw_slave *sdev)
> +{
> + return FIELD_GET(SDW_SCP_STAT_CURR_BANK,
> + sdw_read(sdev, SDW_SCP_CTRL));
sdw_read can fail (miserably)
Konrad
Powered by blists - more mailing lists