linux-kernel - Re: [PATCH v2 2/2] drm: Add missing struct drm_wedge_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aF7BGBE1Gf7vBHDC@black.fi.intel.com>
Date: Fri, 27 Jun 2025 19:04:40 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: André Almeida <andrealmeid@...lia.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux Next Mailing List <linux-next@...r.kernel.org>,
	airlied@...il.com, simona@...ll.ch,
	Krzysztof Karas <krzysztof.karas@...el.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	kernel-dev@...lia.com
Subject: Re: [PATCH v2 2/2] drm: Add missing struct drm_wedge_task_info
 kernel doc

On Fri, Jun 27, 2025 at 04:03:32PM +0300, Raag Jadav wrote:
> On Thu, Jun 19, 2025 at 11:06:55AM -0300, André Almeida wrote:
> > Fix the following kernel doc warning:
> > 
> > include/drm/drm_device.h:40: warning: Function parameter or struct member 'pid' not described in 'drm_wedge_task_info'
> > include/drm/drm_device.h:40: warning: Function parameter or struct member 'comm' not described in 'drm_wedge_task_info'
> > 
> > Fixes: 183bccafa176 ("drm: Create a task info option for wedge events")
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: André Almeida <andrealmeid@...lia.com>
> > ---
> > v2: Add Reported-by tag
> > ---
> >  include/drm/drm_device.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> > index 08b3b2467c4c..aae0800ccef1 100644
> > --- a/include/drm/drm_device.h
> > +++ b/include/drm/drm_device.h
> > @@ -33,6 +33,8 @@ struct pci_controller;
> >  
> >  /**
> >   * struct drm_wedge_task_info - information about the guilty task of a wedge dev
> > + * @pid:	the pid of the task
> > + * @comm:	the command name of the task
> 
> Redundant tabs. A whitespace is ususally good enough for docs.

Also, let's be consistent with struct drm_device for member description.

Raag

> >   */
> >  struct drm_wedge_task_info {
> >  	pid_t pid;
> > -- 
> > 2.49.0
> >