linux-kernel - Re: [PATCH 2/8] arm64: dts: rockchip: Refactor DSI nodes on rk3399 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1c789bf-1369-42ec-8bb3-d7a45c92abf0@cherry.de>
Date: Fri, 27 Jun 2025 18:10:31 +0200
From: Quentin Schulz <quentin.schulz@...rry.de>
To: Diederik de Haas <didi.debian@...ow.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: Dragan Simic <dsimic@...jaro.org>, Johan Jonker <jbx6244@...il.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] arm64: dts: rockchip: Refactor DSI nodes on rk3399
 boards

Hi Diederik,

On 6/27/25 5:16 PM, Diederik de Haas wrote:
> The #address-cells and #size-cells properties are not useful on the DSI
> controller nodes; they are only useful/required on ports and panel(s).
> So remove them from the controller node and add them where actually
> needed on the various rk3399 based boards.
> 
> Next to that, there were several (exact) redefinitions of nodes which
> are already present in rk3399-base.dtsi to add a mipi_out endpoint.
> Simplify that by referencing the mipi_out phandle and add the endpoint
> to that, which allows the removeal of the ports redefinition.
> 
> And fix 1 instance where the mipi_out referenced node was not sorted
> correctly.
> 
> This fixes the following DTB validation warnings:
> 
>    unnecessary #address-cells/#size-cells without "ranges",
>    "dma-ranges" or child "reg" property
> 

Too many unrelated changes in this commit, please split into multiple 
commits.

I could identify:

- moving address-cells/size-cells from SoC.dtsi to board dts(i)s,
- reordering properties to better match DT coding style 
https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
- use phandle to directly access ports,
- reorder DT node to better match DT coding style 
https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html#order-of-nodes

The change for RK3399 Puma Haikou Video Demo DTSO is fine for me.

Cheers,
Quentin