[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aF7EEAxXsurLvIt9@smile.fi.intel.com>
Date: Fri, 27 Jun 2025 19:17:20 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Hans de Goede <hansg@...nel.org>
Cc: LiangCheng Wang <zaq14760@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Andy Shevchenko <andy@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
Bill Wendling <morbo@...gle.com>,
Justin Stitt <justinstitt@...gle.com>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
llvm@...ts.linux.dev
Subject: Re: [PATCH v6] staging: media: atomisp: apply clang-format and fix
checkpatch.pl errors
On Fri, Jun 27, 2025 at 06:05:08PM +0200, Hans de Goede wrote:
> On 27-Jun-25 4:56 PM, LiangCheng Wang wrote:
...
> for (i = 0; i < count; i++) {
> - err = i2c_smbus_write_byte_data(client, reglist[i].reg, reglist[i].val);
> + err = i2c_smbus_write_byte_data(client, reglist[i].reg,
> + reglist[i].val);
> if (err) {
> - dev_err(&client->dev, "write error: wrote 0x%x to offset 0x%x error %d",
>
> The original line here had a length below 100 chars, so it was fine
> and log messages are allowed to go over the length limit
Actually I tend to agree with clang-format on this case and that's why:
until V4L2 becomes less pedantic and fanatic about 80 characters
limit, the 100 is not applicable for this driver to be moved under
their umbrella.
> + dev_err(&client->dev,
> + "write error: wrote 0x%x to offset 0x%x error %d",
> reglist[i].val, reglist[i].reg, err);
> return err;
> }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists