[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <6FF34F9D-4FA6-4463-8922-3894E088CDD2@collabora.com>
Date: Fri, 27 Jun 2025 13:29:31 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Trevor Gross <tmgross@...ch.edu>,
Danilo Krummrich <dakr@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Benno Lossin <lossin@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Krzysztof Wilczyński <kwilczynski@...nel.org>
Cc: linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org,
linux-pci@...r.kernel.org
Subject: Re: [PATCH v5 0/6] rust: add support for request_irq
> On 27 Jun 2025, at 13:21, Daniel Almeida <daniel.almeida@...labora.com> wrote:
>
>
> ---
> Changes in v5:
>
> Thanks, Danilo {
> - Removed extra scope in the examples.
> - Renamed Registration::register() to Registration::new(),
> - Switched to try_pin_init! in Registration::new() (thanks for the
> code and the help, Boqun and Benno)
> - Renamed the trait functions to handle() and handle_on_thread().
> - Introduced IrqRequest with an unsafe pub(crate) constructor
> - Made both register() and the accessors that return IrqRequest public
> the idea is to allow both of these to work:
> // `irq` is an `irq::Registration`
> let irq = pdev.threaded_irq_by_name()?
> and
> // `req` is an `IrqRequest`.
> let req = pdev.irq_by_name()?;
> // `irq` is an `irq::Registration`
> let irq = irq::ThreadedRegistration::new(req)?;
>
> - Added another name in the byname variants. There's now one for the
> request part and the other one to register()
> - Reworked the examples in request.rs
> - Implemented the irq accessors in place for pci.rs
> - Split the platform accessor macros into two
> }
>
> - Added a rust helper for pci_irq_vectors if !CONFIG_PCI_MSI (thanks,
> Intel 0day bot)
> - Link to v4: https://lore.kernel.org/r/20250608-topics-tyr-request_irq-v4-0-81cb81fb8073@collabora.com
>
Sorry, I forgot to mention that this now depends on the new Devres series at [0].
[0] https://git.kernel.org/pub/scm/linux/kernel/git/dakr/linux.git/log/?h=rust/devres
Powered by blists - more mailing lists