linux-kernel - Re: [PATCH v3 29/64] objtool: Mark prefix functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dy47cs5h55my4tsldr5e64wgk7njw4a2ka7uu766ptmeyudemh@vtmbvqb52yjc>
Date: Fri, 27 Jun 2025 09:53:22 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, 
	Petr Mladek <pmladek@...e.com>, Miroslav Benes <mbenes@...e.cz>, 
	Joe Lawrence <joe.lawrence@...hat.com>, live-patching@...r.kernel.org, Song Liu <song@...nel.org>, 
	laokz <laokz@...mail.com>, Jiri Kosina <jikos@...nel.org>, 
	Marcos Paulo de Souza <mpdesouza@...e.com>, Weinan Liu <wnliu@...gle.com>, 
	Fazla Mehrab <a.mehrab@...edance.com>, Chen Zhongjin <chenzhongjin@...wei.com>, 
	Puranjay Mohan <puranjay@...nel.org>, Dylan Hatch <dylanbhatch@...gle.com>
Subject: Re: [PATCH v3 29/64] objtool: Mark prefix functions

On Fri, Jun 27, 2025 at 12:31:58PM +0200, Peter Zijlstra wrote:
> > +static inline bool is_prefix_func(struct symbol *sym)
> > +{
> > +	return is_func_sym(sym) && sym->prefix;
> > +}
> 
> func_is_prefix() ?

is the function a prefix though?

> Also, since we only ever set sym->prefix when is_func_sym(), this helper
> could avoid checking that again.

Indeed...

-- 
Josh