linux-kernel - Re: [Ping][PATCH] perf list: Add IBM z17 event descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVcNqE9txXQgO+EUV6xz3Mvsqin9FP8FNUztPp35LW2Ng@mail.gmail.com>
Date: Fri, 27 Jun 2025 09:55:14 -0700
From: Ian Rogers <irogers@...gle.com>
To: Thomas Richter <tmricht@...ux.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-s390@...r.kernel.org, linux-perf-users@...r.kernel.org, 
	namhyung@...nel.org, agordeev@...ux.ibm.com, gor@...ux.ibm.com, 
	hca@...ux.ibm.com, japo@...ux.ibm.com
Subject: Re: [Ping][PATCH] perf list: Add IBM z17 event descriptions

On Fri, Jun 27, 2025 at 1:13 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
>
> On 6/24/25 08:35, Thomas Richter wrote:
>
> Gently Ping
>
> Ian, I have responded to your comments some days ago.

Thanks Thomas, minor nit in your explanation the events must exist as
they are in json, but the json events are only exposed if the PMU is
present, so the has_event is more of a has_pmu test. Maybe we should
add a function like this to the metrics to make this kind of case
clearer. Maybe `perf list` should test the events of a metric and hide
metrics when the events aren't available to avoid the have_event
logic. I'm a bit uncomfortable with that as the events may not be
available because of permission issues, but it'd still be useful to
know the metrics are around. Anyway I'm digressing.

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian