[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aF7ZEi9qQxshnWed@vaman>
Date: Fri, 27 Jun 2025 10:46:58 -0700
From: Vinod Koul <vkoul@...nel.org>
To: srinivas.kandagatla@....qualcomm.com
Cc: broonie@...nel.org, yung-chuan.liao@...ux.intel.com,
pierre-louis.bossart@...ux.dev, lgirdwood@...il.com, perex@...ex.cz,
tiwai@...e.com, krzysztof.kozlowski@...aro.org,
linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/4] soundwire: bus: add of_sdw_find_device_by_node helper
On 27-06-25, 16:51, srinivas.kandagatla@....qualcomm.com wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>
> There has been more than 3 instances of this helper in multiple codec
> drivers, it does not make sense to keep duplicating this part of code.
>
> Lets add a helper of_sdw_find_device_by_node for codec drivers to use it.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
> drivers/soundwire/slave.c | 6 ++++++
> include/linux/soundwire/sdw.h | 9 +++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
> index d2d99555ec5a..3d4d00188c26 100644
> --- a/drivers/soundwire/slave.c
> +++ b/drivers/soundwire/slave.c
> @@ -273,4 +273,10 @@ int sdw_of_find_slaves(struct sdw_bus *bus)
> return 0;
> }
>
> +struct device *of_sdw_find_device_by_node(struct device_node *np)
> +{
> + return bus_find_device_by_of_node(&sdw_bus_type, np);
> +}
> +EXPORT_SYMBOL_GPL(of_sdw_find_device_by_node);
Helper for single code lines?? why!
> +
> MODULE_IMPORT_NS("SND_SOC_SDCA");
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index 2362f621d94c..84d1a101b155 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -18,6 +18,7 @@
>
> struct dentry;
> struct fwnode_handle;
> +struct device_node;
>
> struct sdw_bus;
> struct sdw_slave;
> @@ -1080,6 +1081,8 @@ int sdw_stream_add_slave(struct sdw_slave *slave,
> int sdw_stream_remove_slave(struct sdw_slave *slave,
> struct sdw_stream_runtime *stream);
>
> +struct device *of_sdw_find_device_by_node(struct device_node *np);
> +
> int sdw_slave_get_scale_index(struct sdw_slave *slave, u8 *base);
>
> /* messaging and data APIs */
> @@ -1113,6 +1116,12 @@ static inline int sdw_stream_remove_slave(struct sdw_slave *slave,
> return -EINVAL;
> }
>
> +static inline struct device *of_sdw_find_device_by_node(struct device_node *np)
> +{
> + WARN_ONCE(1, "SoundWire API is disabled");
> + return NULL;
> +}
> +
> /* messaging and data APIs */
> static inline int sdw_read(struct sdw_slave *slave, u32 addr)
> {
> --
> 2.49.0
--
~Vinod
Powered by blists - more mailing lists