linux-kernel - Re: [PATCH v2] dmaengine: idxd: Remove _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aF7bDA-evv2IsMoi@vaman>
Date: Fri, 27 Jun 2025 10:55:24 -0700
From: Vinod Koul <vkoul@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yi Sun <yi.sun@...el.com>, gordon.jin@...el.com,
	yi.sun@...ux.intel.com,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Dave Jiang <dave.jiang@...el.com>, Fenghua Yu <fenghuay@...dia.com>
Subject: Re: [PATCH v2] dmaengine: idxd: Remove __packed from structures

On 27-06-25, 07:05, Andy Shevchenko wrote:
> Thu, Jun 26, 2025 at 03:48:11PM -0700, Vinod Koul kirjoitti:
> > 
> > On Fri, 04 Apr 2025 13:36:14 +0800, Yi Sun wrote:
> > > The __packed attribute introduces potential unaligned memory accesses
> > > and endianness portability issues. Instead of relying on compiler-specific
> > > packing, it's much better to explicitly fill structure gaps using padding
> > > fields, ensuring natural alignment.
> > > 
> > > Since all previously __packed structures already enforce proper alignment
> > > through manual padding, the __packed qualifiers are unnecessary and can be
> > > safely removed.
> 
> [...]
> 
> > Applied, thanks!
> 
> Please, don't or fix it ASAP. This patch is broken in the formal things,
> i.e. changelog entry must not disrupt SoB chain. I'm not sure if Stephen's
> scripts will catch this up on Linux Next integration, though.

Thanks for letting me know. My script didnt catch it, will check why.
I have fixed it up now

-- 
~Vinod