linux-kernel - Re: [PATCH V3] fs: generalize anon_inode_make_secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <685ee11da5119_2ec7172946a@iweiny-mobl.notmuch>
Date: Fri, 27 Jun 2025 13:21:17 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Shivank Garg <shivankg@....com>, <david@...hat.com>,
	<akpm@...ux-foundation.org>, <brauner@...nel.org>, <paul@...l-moore.com>,
	<rppt@...nel.org>, <viro@...iv.linux.org.uk>
CC: <seanjc@...gle.com>, <vbabka@...e.cz>, <willy@...radead.org>,
	<pbonzini@...hat.com>, <tabba@...gle.com>, <afranji@...gle.com>,
	<ackerleytng@...gle.com>, <shivankg@....com>, <jack@...e.cz>,
	<hch@...radead.org>, <cgzones@...glemail.com>, <ira.weiny@...el.com>,
	<roypat@...zon.co.uk>, <linux-fsdevel@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>, <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH V3] fs: generalize anon_inode_make_secure_inode() and fix
 secretmem LSM bypass

Shivank Garg wrote:
> Extend anon_inode_make_secure_inode() to take superblock parameter and
> make it available via fs.h. This allows other subsystems to create
> anonymous inodes with proper security context.
> 
> Use this function in secretmem to fix a security regression, where
> S_PRIVATE flag wasn't cleared after alloc_anon_inode(), causing
> LSM/SELinux checks to be skipped.
> 
> Using anon_inode_make_secure_inode() ensures proper security context
> initialization through security_inode_init_security_anon().
> 
> Fixes: 2bfe15c52612 ("mm: create security context for memfd_secret inodes")
> Suggested-by: David Hildenbrand <david@...hat.com>
> Suggested-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Reviewed-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]