linux-kernel - RE: [PATCH v5 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB6568D1E1CA64E22D7261F725F145A@TYZPR06MB6568.apcprd06.prod.outlook.com>
Date: Fri, 27 Jun 2025 02:22:37 +0000
From: Jammy Huang <jammy_huang@...eedtech.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>, Rob Herring
	<robh@...nel.org>
CC: "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "joel@....id.au" <joel@....id.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>
Subject: RE: [PATCH v5 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series
 SoC

> On Wed, 2025-06-25 at 10:50 -0500, Rob Herring wrote:
> > On Wed, Jun 25, 2025 at 03:34:16PM +0800, Jammy Huang wrote:
> > > Introduce the mailbox module for AST27XX series SoC, which is
> > > responsible for interchanging messages between asymmetric processors.
> > >
> > > Signed-off-by: Jammy Huang <jammy_huang@...eedtech.com>
> >
> 
> *snip*
> 
> > > +properties:
> > > +  compatible:
> > > +    const: aspeed,ast2700-mailbox
> > > +
> > > +  reg:
> > > +    maxItems: 2
> > > +    description:
> > > +      Contains the base addresses and sizes of the mailbox
> > > +controller. 1st one
> > > +      is for TX control register; 2nd one is for RX control register.
> >
> > Instead, just:
> >
> > items:
> >   - description: TX control register
> >   - description: RX control register
> 
> Maybe also specify reg-names with "tx" and "rx"? That way we can use
> devm_platform_ioremap_resource_byname() in the linux driver
> implementation, which should look tidier.
Sounds good. I will do it.
> 
> Andrew

Regards
Jammy