linux-kernel - Re: [PATCH 4/9] Doing it for the consistency in the tree,eliminating the full path to the script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be91d221-0182-44bf-8d70-131ed347b738@sabinyo.mountain>
Date: Fri, 27 Jun 2025 14:07:07 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Bhaskar Chowdhury <unixbhaskar@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] Doing it for the consistency in the tree,eliminating
 the full path to the script

On Sat, Jun 21, 2025 at 04:08:53AM +0530, Bhaskar Chowdhury wrote:
> Just try to making things consistent across the tree by eliminating full path
> to the script.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
>  smatch_scripts/find_null_params.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/smatch_scripts/find_null_params.sh b/smatch_scripts/find_null_params.sh
> index 9e39146d2d40..a78eb7623fb4 100755
> --- a/smatch_scripts/find_null_params.sh
> +++ b/smatch_scripts/find_null_params.sh
> @@ -3,7 +3,7 @@
>  file=$1
> 
>  if [[ "$file" = "" ]] ; then
> -    echo "Usage:  $0 <file with smatch messages>"
> +	echo "Usage:  $(basename $0) <file with smatch messages>"

I don't love tab indents for bash scripts.  I know that the kernel does
this for scripts but I don't love it there either.  So I've been hand
editing these patches.  It's easy for me to hand edit these in my email
client so no worries.

>      exit 1
>  fi
> 
> @@ -13,7 +13,7 @@ cat null_calls.txt unchecked | sort | uniq -d > null_params.txt
>  IFS="
>  "
>  for i in $(cat null_params.txt) ; do
> -	grep "$i" $file | grep -w undefined
> +	grep "$i" $file | grep -w undefined

In this case I think you were removing a space from the end of the line
but somehow your email client seems to have deleted it so the patch
didn't apply.  I did this manually as well, but you may want to fix that.

Anyway, all of these are applied now.

regards,
dan carpenter