linux-kernel - Re: [PATCH v5 5/6] rust: platform: add irq accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aF7tknVzLbdN71kw@pollux>
Date: Fri, 27 Jun 2025 21:14:26 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Benno Lossin <lossin@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v5 5/6] rust: platform: add irq accessors

On Fri, Jun 27, 2025 at 09:10:22PM +0200, Danilo Krummrich wrote:
> On Fri, Jun 27, 2025 at 01:21:07PM -0300, Daniel Almeida wrote:
> > +macro_rules! define_irq_accessor_by_index {
> > +    ($(#[$meta:meta])* $fn_name:ident, $request_fn:ident, $reg_type:ident, $handler_trait:ident) => {
> > +        $(#[$meta])*
> > +        pub fn $fn_name<T: irq::$handler_trait + 'static>(
> > +            &self,
> > +            index: u32,
> > +            flags: irq::flags::Flags,
> > +            name: &'static CStr,
> > +            handler: T,
> > +        ) -> Result<impl PinInit<irq::$reg_type<T>, Error> + '_> {
> > +            let request = self.$request_fn(index)?;
> > +
> > +            Ok(irq::$reg_type::<T>::new(
> > +                request,
> > +                flags,
> > +                name,
> > +                handler,
> > +            ))
> > +        }
> > +    };
> > +}
> > +
> > +macro_rules! define_irq_accessor_by_name {
> > +    ($(#[$meta:meta])* $fn_name:ident, $request_fn:ident, $reg_type:ident, $handler_trait:ident) => {
> > +        $(#[$meta])*
> > +        pub fn $fn_name<T: irq::$handler_trait + 'static>(
> > +            &self,
> > +            irq_name: &'static CStr,
> > +            name: &'static CStr,
> > +            flags: irq::flags::Flags,
> > +            handler: T,
> > +        ) -> Result<impl PinInit<irq::$reg_type<T>, Error> + '_> {
> > +            let request = self.$request_fn(irq_name)?;
> > +
> > +            Ok(irq::$reg_type::<T>::new(
> > +                request,
> > +                flags,
> > +                name,
> > +                handler,
> > +            ))
> > +        }
> > +    };
> > +}
> 
> NIT: Please make the order of name and flags the same for both macros.

Ideally, first flags, then name, since this is the order used everywhere else.