[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250627193613.552193-1-abdalla.ahmad@sesame.org.jo>
Date: Fri, 27 Jun 2025 22:36:13 +0300
From: Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>
To: Dave Penkler <dpenkler@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michael Rubin <matchstick@...erthere.org>,
Dan Carpenter <dan.carpenter@...aro.org>,
Arnd Bergmann <arnd@...db.de>,
Paul Retourné <paul.retourne@...nge.fr>,
Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>,
linux-staging@...ts.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] drivers: staging: gpib: minor fixes for some C macros.
Ran checkpatch.pl on drivers/staging/gpib/, found the following:
- gpio: gpib_bitbang.c: wrapped LINVAL macro w/ parenthesis.
- hp_82341: hp_82341.c: Used comments instead of "#if 0"
- tnt4882: tnt4882_gpib.c: Used comments instead of "#if 0"
Signed-off-by: Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>
---
drivers/staging/gpib/gpio/gpib_bitbang.c | 4 ++--
drivers/staging/gpib/hp_82341/hp_82341.c | 14 +++++++-------
drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 14 +++++++-------
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
index 625fef24a0bf..45cf4571c58d 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -47,10 +47,10 @@
dev_dbg(board->gpib_dev, frm, ## __VA_ARGS__); } \
while (0)
-#define LINVAL gpiod_get_value(DAV), \
+#define LINVAL (gpiod_get_value(DAV), \
gpiod_get_value(NRFD), \
gpiod_get_value(NDAC), \
- gpiod_get_value(SRQ)
+ gpiod_get_value(SRQ))
#define LINFMT "DAV: %d NRFD:%d NDAC: %d SRQ: %d"
#include "gpibP.h"
diff --git a/drivers/staging/gpib/hp_82341/hp_82341.c b/drivers/staging/gpib/hp_82341/hp_82341.c
index 1b0822b2a3b8..f641613e128b 100644
--- a/drivers/staging/gpib/hp_82341/hp_82341.c
+++ b/drivers/staging/gpib/hp_82341/hp_82341.c
@@ -805,14 +805,14 @@ static void hp_82341_detach(struct gpib_board *board)
hp_82341_free_private(board);
}
-#if 0
/* unused, will be needed when the driver is turned into a pnp_driver */
-static const struct pnp_device_id hp_82341_pnp_table[] = {
- {.id = "HWP1411"},
- {.id = ""}
-};
-MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table);
-#endif
+/*
+ * static const struct pnp_device_id hp_82341_pnp_table[] = {
+ * {.id = "HWP1411"},
+ * {.id = ""}
+ * };
+ * MODULE_DEVICE_TABLE(pnp, hp_82341_pnp_table);
+ */
static int __init hp_82341_init_module(void)
{
diff --git a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
index a17b69e34986..7d679604488e 100644
--- a/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
+++ b/drivers/staging/gpib/tnt4882/tnt4882_gpib.c
@@ -1369,14 +1369,14 @@ static struct pci_driver tnt4882_pci_driver = {
.probe = &tnt4882_pci_probe
};
-#if 0
/* unused, will be needed when the driver is turned into a pnp_driver */
-static const struct pnp_device_id tnt4882_pnp_table[] = {
- {.id = "NICC601"},
- {.id = ""}
-};
-MODULE_DEVICE_TABLE(pnp, tnt4882_pnp_table);
-#endif
+/*
+ * static const struct pnp_device_id tnt4882_pnp_table[] = {
+ * {.id = "NICC601"},
+ * {.id = ""}
+ * };
+ * MODULE_DEVICE_TABLE(pnp, tnt4882_pnp_table);
+ */
#ifdef CONFIG_GPIB_PCMCIA
static struct gpib_interface ni_pcmcia_interface;
--
2.43.0
Powered by blists - more mailing lists