[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250627193818.GA4051037-robh@kernel.org>
Date: Fri, 27 Jun 2025 14:38:18 -0500
From: Rob Herring <robh@...nel.org>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Niklas Söderlund <niklas.soderlund@...natech.se>,
Julien Massot <julien.massot@...labora.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Linus Walleij <linus.walleij@...aro.org>,
"open list:MAXIM GMSL2 SERIALIZERS AND DESERIALIZERS" <linux-media@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" <linux-arm-kernel@...ts.infradead.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
"open list:GPIO SUBSYSTEM:Keyword:(devm_)?gpio_(request|free|direction|get|set)" <linux-gpio@...r.kernel.org>,
Cosmin Tanislav <cosmin.tanislav@...log.com>
Subject: Re: [PATCH v4 04/19] dt-bindings: media: i2c: max96717: add support
for pinctrl/pinconf
On Wed, Jun 18, 2025 at 12:58:40PM +0300, Cosmin Tanislav wrote:
> MAX96717 is capable of configuring various pin properties.
>
> Add pinctrl/pinconf properties to support this usecase.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> ---
> .../bindings/media/i2c/maxim,max96717.yaml | 110 ++++++++++++++++++
> 1 file changed, 110 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml
> index 167c3dd50683..5998e2518be9 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml
> @@ -121,6 +121,116 @@ required:
> - reg
> - ports
>
> +patternProperties:
> + '-pins$':
> + type: object
> + additionalProperties: false
> +
> + properties:
> + function:
> + enum: [gpio, rclkout]
> +
> + pins: true
> + drive-open-drain: true
> + drive-push-pull: true
> + bias-disable: true
> + output-disable: true
> + output-enable: true
> + output-low: true
> + output-high: true
> + input-enable: true
> +
> + slew-rate:
> + description: |
> + Slew rate.
> + 0 - Fastest
> + 1 - Fast
> + 2 - Slow
> + 3 - Slowest
> + maximum: 3
> +
> + bias-pull-up:
> + oneOf:
> + - type: boolean
> + description: Enable regular 40kOhm pull-up
> + - enum: [ 40000, 1000000 ]
> + description: Enable either the 40kOhm or the 1MOhm pull-up
> +
> + bias-pull-down:
> + oneOf:
> + - type: boolean
> + description: Enable regular 40kOhm pull-down
> + - enum: [ 40000, 1000000 ]
> + description: Enable either the 40kOhm or the 1MOhm pull-down
> +
> + maxim,jitter-compensation:
> + type: boolean
> + description: Enables jitter compensation.
> +
> + maxim,gmsl-tx:
> + type: boolean
> + description: Enable transmitting pin value to GMSL link.
> +
> + maxim,gmsl-rx:
> + type: boolean
> + description: Enable receiving pin value from GMSL link.
> +
> + maxim,gmsl-tx-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Identifier used while transmitting value to GMSL link.
> + Default value matches the pin number.
> + minimum: 0
The minimum is already 0 being unsigned. Elsewhere too.
With that,
Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
Powered by blists - more mailing lists